Skip to content

ExceptionInfo.from_current: pass through exprinfo - #6002

Merged
blueyed merged 1 commit into
pytest-dev:featuresfrom
blueyed:exprinfo-arg
Oct 19, 2019
Merged

ExceptionInfo.from_current: pass through exprinfo#6002
blueyed merged 1 commit into
pytest-dev:featuresfrom
blueyed:exprinfo-arg

Conversation

@blueyed

@blueyed blueyed commented Oct 19, 2019

Copy link
Copy Markdown
Contributor

This was lost in 11f1f79.

@blueyed
blueyed requested a review from bluetech October 19, 2019 01:03
@RonnyPfannschmidt

Copy link
Copy Markdown
Member

Good find, got a idea for a test?

@bluetech bluetech left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

@blueyed

blueyed commented Oct 19, 2019

Copy link
Copy Markdown
Contributor Author

@RonnyPfannschmidt
Not from the top of my head - do you have one?

@blueyed

blueyed commented Oct 19, 2019

Copy link
Copy Markdown
Contributor Author

I do not fully grasp the API there btw, I think something more explicit like #6003 makes sense here.

@blueyed
blueyed merged commit 119bf66 into pytest-dev:features Oct 19, 2019
@blueyed
blueyed deleted the exprinfo-arg branch October 19, 2019 17:20
@RonnyPfannschmidt

Copy link
Copy Markdown
Member

@blueyed should we add a follow-up task to make a test for this one, i have no idea myself off hand

@blueyed

blueyed commented Oct 19, 2019

Copy link
Copy Markdown
Contributor Author

@RonnyPfannschmidt not really necessary AFAICS.
But feedback on #6003 / the idea from there would be good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants