Fix incorrect result of getmodpath method. - #6202
Merged
Merged
Conversation
asottile
reviewed
Nov 17, 2019
asottile
left a comment
asottile
left a comment
Member
There was a problem hiding this comment.
looks good! mind adding a quick test which demonstrates this change?
Contributor
|
@linw1995 |
Contributor
Author
Member
|
Thanks @linw1995, great finding and great PR. 👍 We could make a separate test for the fix, but the way it is now looks enough to me. 😁 |
nicoddemus
approved these changes
Nov 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #6189