Fix serialization of 'None' reprcrashes - #6412
Merged
Merged
Conversation
Contributor
|
Maybe interesting in this context: https://github.com/ionelmc/python-tblib |
blueyed
reviewed
Jan 7, 2020
Tracebacks coming from remote processes crated by the multiprocess module will contain "RemoteTracebacks" which don't have a 'reprcrash' attribute Fix pytest-dev#5971
nicoddemus
force-pushed
the
remote-tb-5971
branch
from
January 7, 2020 01:06
32bd9b9 to
0e00069
Compare
Member
Author
Very interesting, didn't know about that lib, thanks. 👍 |
asottile
approved these changes
Jan 7, 2020
asottile
left a comment
asottile
left a comment
Member
There was a problem hiding this comment.
otherwise looks good, feel free to ignore and ship anyway
As requested in review
nicoddemus
commented
Jan 7, 2020
| """ | ||
| testdir.makepyfile( | ||
| """ | ||
| from concurrent.futures import ProcessPoolExecutor |
Member
Author
There was a problem hiding this comment.
Also this is easier to understand the original issue IMO
Member
Author
|
@asottile please merge if CI passes and you are OK with the latest changes. 🙏 |
nicoddemus
pushed a commit
to nicoddemus/pytest
that referenced
this pull request
Jan 14, 2020
Somehow in Python 3.5 on Windows this test fails with:
File "c:\hostedtoolcache\windows\python\3.5.4\x64\Lib\multiprocessing\connection.py", line 302, in _recv_bytes
overlapped=True)
OSError: [WinError 6] The handle is invalid
This only happens in this platform and Python version, decided to use
a dummy traceback as originally done in pytest-dev#6412.
blueyed
pushed a commit
to blueyed/pytest
that referenced
this pull request
Jan 16, 2020
Somehow in Python 3.5 on Windows this test fails with:
File "c:\hostedtoolcache\windows\python\3.5.4\x64\Lib\multiprocessing\connection.py", line 302, in _recv_bytes
overlapped=True)
OSError: [WinError 6] The handle is invalid
This only happens in this platform and Python version, decided to use
a dummy traceback as originally done in pytest-dev#6412.
(cherry picked from commit b9c136b)
blueyed
pushed a commit
to blueyed/pytest
that referenced
this pull request
Jan 21, 2020
Somehow in Python 3.5 on Windows this test fails with:
File "c:\hostedtoolcache\windows\python\3.5.4\x64\Lib\multiprocessing\connection.py", line 302, in _recv_bytes
overlapped=True)
OSError: [WinError 6] The handle is invalid
This only happens in this platform and Python version, decided to use
a dummy traceback as originally done in pytest-dev#6412.
(cherry picked from commit b9c136b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracebacks coming from remote processes crated by the multiprocess module
will contain "RemoteTracebacks" which don't have a 'reprcrash' attribute.
I've made sure to test this fixes in xdist.
Fix #5971