Skip to content

ci: Travis: Python 3.5.1 via Trusty - #6440

Merged
blueyed merged 2 commits into
pytest-dev:masterfrom
blueyed:py351
Jan 14, 2020
Merged

ci: Travis: Python 3.5.1 via Trusty#6440
blueyed merged 2 commits into
pytest-dev:masterfrom
blueyed:py351

Conversation

@blueyed

@blueyed blueyed commented Jan 10, 2020

Copy link
Copy Markdown
Contributor

Python 3.5.0 caused flaky failures before
(#5795), hopefully this is
more stable.

This is pulled out of #6435,
which adds code specific for Python < 3.5.2, and therefore it makes
sense to test it.

@blueyed blueyed mentioned this pull request Jan 10, 2020
Merged
2 tasks
@nicoddemus

nicoddemus commented Jan 11, 2020

Copy link
Copy Markdown
Member

Seems still needs work:

  File "/home/travis/build/pytest-dev/pytest/.tox/py35-xdist/lib/python3.5/site-packages/hypothesis/internal/compat.py", line 22, in <module>
    from typing import Tuple, Type  # noqa
ImportError: cannot import name 'Type'

@The-Compiler

The-Compiler commented Jan 11, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

@nicoddemus See my comment here: #6435 (comment)

Should be fixed in hypothesis 5.1.3 which was released today.

@nicoddemus

nicoddemus commented Jan 11, 2020

Copy link
Copy Markdown
Member

Cool, thanks for the link. 👍

@blueyed

blueyed commented Jan 11, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Still fails with hypothesis 5.1.4: HypothesisWorks/hypothesis#2318

This was referenced Jan 11, 2020
Closed
Merged
@blueyed

blueyed commented Jan 12, 2020

Copy link
Copy Markdown
Contributor Author

[gw1] linux -- Python 3.5.1 /home/travis/build/pytest-dev/pytest/.tox/py35-xdist/bin/python
worker 'gw1' crashed while running 'testing/test_config.py::test_config_blocked_default_plugins[monkeypatch]'

gw2 then does not re-try the test (xdist issue?).

I think we should run this only with a subset to cover enough of 3.5.{0,1} specific code.

@blueyed

blueyed commented Jan 12, 2020

Copy link
Copy Markdown
Contributor Author

Should be good now.

blueyed added a commit to blueyed/pytest that referenced this pull request Jan 12, 2020
@blueyed
test pytest-dev#6440
a4859ef
blueyed added a commit to blueyed/pytest that referenced this pull request Jan 13, 2020
@blueyed
ci: Travis: test with Python 3.5.1 (#155)
f478b06 
This covers special handling for typing.

Ref: pytest-dev#6440.
@blueyed
ci: Travis: Python 3.5.1 via Trusty
4ff7453 
Python 3.5.0 caused flaky failures before
(pytest-dev#5795).

This is pulled out of pytest-dev#6435,
which adds code specific for Python < 3.5.2.

It only runs a specific test, while collecting everything to get
coverage of the version specific code around typing.
@blueyed
Remove "pragma: no cover" comments
f0c7f21
@blueyed

blueyed commented Jan 14, 2020

Copy link
Copy Markdown
Contributor Author

Would like to get this merged for #6435.

@blueyed
blueyed merged commit b2cb87f into pytest-dev:master Jan 14, 2020
@blueyed
blueyed deleted the py351 branch January 14, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blueyed @nicoddemus @The-Compiler