Skip to content

ci: codecov: only use "comment: off" - #6567

Merged
blueyed merged 1 commit into
pytest-dev:masterfrom
blueyed:codecov-config
Jan 25, 2020
Merged

ci: codecov: only use "comment: off"#6567
blueyed merged 1 commit into
pytest-dev:masterfrom
blueyed:codecov-config

Conversation

@blueyed

@blueyed blueyed commented Jan 25, 2020

Copy link
Copy Markdown
Contributor

The changes status is quite buggy, remove it for now.
This just uses "comment: off" then.

The changes status is quite buggy, remove it for now.
This just uses "comment: off" then.
@bluetech

bluetech commented Jan 25, 2020

Copy link
Copy Markdown
Member

This check seemingly always fails, looking selfishly at my own PRs, I would be happy to see it gone.

@blueyed

blueyed commented Jan 25, 2020

Copy link
Copy Markdown
Contributor Author

This check seemingly always fails, looking selfishly at my own PRs, I would be happy to see it gone.

Not always, but often. It seems like they have issues with finding the correct base to compare against. (talked briefly with their support)

@blueyed
blueyed merged commit 0d55fb3 into pytest-dev:master Jan 25, 2020
@blueyed
blueyed deleted the codecov-config branch January 25, 2020 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants