Skip to content

Remove a couple of redundant commas - #6568

Merged
blueyed merged 1 commit into
pytest-dev:masterfrom
bluetech:redundant-commas
Jan 25, 2020
Merged

Remove a couple of redundant commas#6568
blueyed merged 1 commit into
pytest-dev:masterfrom
bluetech:redundant-commas

Conversation

@bluetech

Copy link
Copy Markdown
Member

Mypy complains about this once the function is typed:

src/_pytest/main.py:85: error: "_addoption" of "OptionGroup" does not return a value
src/_pytest/main.py:133: error: "addoption" of "OptionGroup" does not return a value

@blueyed

blueyed commented Jan 25, 2020

Copy link
Copy Markdown
Contributor

This can go into master, right?
We can merge it afterwards into features again.

Mypy complains about this once the function is typed:

src/_pytest/main.py:85: error: "_addoption" of "OptionGroup" does not return a value
src/_pytest/main.py:133: error: "addoption" of "OptionGroup" does not return a value
@blueyed

blueyed commented Jan 25, 2020

Copy link
Copy Markdown
Contributor

I'll go ahead and rebase it already.

@blueyed
blueyed changed the base branch from features to master January 25, 2020 13:13
@blueyed
blueyed merged commit 2da331e into pytest-dev:master Jan 25, 2020
@bluetech

Copy link
Copy Markdown
Member Author

Thanks @blueyed!

@bluetech
bluetech deleted the redundant-commas branch February 28, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants