Skip to content

Inline FunctionMixin with Function - #6664

Merged
blueyed merged 3 commits into
pytest-dev:featuresfrom
blueyed:rm-FunctionMixin
Feb 3, 2020
Merged

Inline FunctionMixin with Function#6664
blueyed merged 3 commits into
pytest-dev:featuresfrom
blueyed:rm-FunctionMixin

Conversation

@blueyed

@blueyed blueyed commented Feb 3, 2020

Copy link
Copy Markdown
Contributor

Generator was removed in 7eb28f9, and this pleases mypy to correctly
complain that FunctionMixin has no config (within
_prunetraceback).

`Generator` was removed in 7eb28f9, and this pleases mypy to correctly
complain that `FunctionMixin` has no `config` (within
`_prunetraceback`).
@blueyed

blueyed commented Feb 3, 2020

Copy link
Copy Markdown
Contributor Author

codecov/patch — 96.66% of diff hit (target 96.8%)

Will not cover that here likely, but likely later when fixing _prunetraceback (likely related to #6657).

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice followup

@blueyed
blueyed merged commit 8ec4d03 into pytest-dev:features Feb 3, 2020
@blueyed
blueyed deleted the rm-FunctionMixin branch February 3, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants