Skip to content

feat(lazer): Update EVM example to attach fee for verification#39

Merged
darunrs merged 5 commits into
mainfrom
attach-fees-example-contract-lazer
Dec 17, 2024
Merged

feat(lazer): Update EVM example to attach fee for verification#39
darunrs merged 5 commits into
mainfrom
attach-fees-example-contract-lazer

Conversation

@darunrs

@darunrs darunrs commented Dec 12, 2024

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread lazer/evm/test/ExampleReceiver.t.sol Outdated
receiver.updatePrice(update);
vm.deal(consumer, 1 ether);
vm.prank(consumer);
receiver.updatePrice{value: pythLazer.verification_fee()}(update);

@darunrs darunrs Dec 12, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I attach more fee and call verifyUpdate{value: msg.value}() the refund fails and I get the following error:
image

If I instead call verifyUpdate{value: 1 wei}(), then all calls succeed but the ending balances are all wrong.

If I attach more fee and then comment out the refund in updatePrice, the final assert fails saying that consumer has the full amount of ether. Yet, pythLazer was still paid, and now the receiver contract got paid the 9 wei difference. So, money was made out of thin air.

I think I might be missing something simple, but not sure what it is...

Things I can think of which might matter are: Payable vs non-payable addresses and contracts with receive/fallback functions.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Riateche helped me out. The issue was that when I called vm.prank() before calling the updatePrice function, I was calling pythLazer.verification_fee() to get the fee to attach. This consumed the prank and led to some other default address making the call for verifyUpdate(). This default address doesn't have the receive/fallback functions so it fails. But storing the fee as a uint256 and making sure prank correctly targets the actual call, the test succeeds.

@darunrs darunrs changed the title feat: Add fee but still failing feat(lazer): Update EVM example to attach fee for verification Dec 13, 2024
@darunrs darunrs marked this pull request as ready for review December 13, 2024 18:42
Comment thread lazer/evm/src/ExampleReceiver.sol Outdated
Comment thread lazer/evm/src/ExampleReceiver.sol Outdated
@darunrs darunrs merged commit 7ad9dc4 into main Dec 17, 2024
@darunrs darunrs deleted the attach-fees-example-contract-lazer branch December 17, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants