Preserve leading fractional zeros in plural operands - #1342
Open
emme1t wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extract_operands()undercounts visible fractional digits for numbers below 1 when the fractional part starts with zeros. For example,Decimal('0.001')currently producesv = 1, w = 1; both operands should be 3 under the CLDR operand definitions.This affects locale plural selection:
The Latvian rule distinguishes
v = 2fromv != 2.Decimal.as_tuple().digitsomits leading fractional zeros, so the current calculation treats0.011like a number with two fractional digits.Compute
vfrom the decimal exponent and derivewby subtracting the trailing-zero count. Fractional valuesfandtretain their existing calculation. Tests cover leading zeros, trailing zeros, signed values, decimal zero, a positive exponent, float input, custom plural rules, and the Latvian locale rule.Validation on Windows / Python 3.13.13 with the repository's CLDR 48.2 import:
python -m pytest tests/test_plural.py -q: 49 passed.python -m pytest -q: 7839 passed, 9 skipped, 2 xfailed.git diff --checkpasses.AI assistance: Prepared with Codex. The reproducer and tests listed above were executed locally.