Skip to content

stop "conf"s all being the same dict #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iandobbie merged 1 commit into from
Jun 16, 2021
Merged

stop "conf"s all being the same dict #212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion microscope/device_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def device(
cls: typing.Callable,
host: str,
port: int,
conf: typing.Mapping[str, typing.Any] = {},
conf: typing.Mapping[str, typing.Any] = None,
uid: typing.Optional[str] = None,
):
"""Define devices and where to serve them.
Expand Down Expand Up @@ -119,6 +119,8 @@ def construct_devices() -> typing.Dict[str, Device]:
]

"""
if conf is None:
conf = {}
if not callable(cls):
raise TypeError("cls must be a callable")
elif isinstance(cls, type):
Expand Down