Speed up Image.filter() for I;16*#9760
Draft
akx wants to merge 6 commits into
Draft
Conversation
Also adds LA to some tests as a side effect
Merging this PR will improve performance by ×2.4
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ⚡ | test_filter[1024x1024-L-Smooth] |
24.3 ms | 10.1 ms | ×2.4 |
| ⚡ | test_filter[1024x1024-L-Sharpen] |
24.2 ms | 10.1 ms | ×2.4 |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing akx:faster-filter-still (525c545) with main (1cf685c)
Footnotes
-
2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
This comment was marked as outdated.
This comment was marked as outdated.
80ed36b to
e2022ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up on #8438; same split-by-mode optimization technique as in #9737.
Also fixes up things around
ImageFilter:test_consistency_*tests didn't use themodeparametrization at all and just ran the same test N timestest_crashclaimed ImageFilter would crash on images smaller than the kernel; it doesn't, it just returns the same image.test_crashhad hadassert_no_exceptionsometime before 3ec5059?Kernelclaimed only a couple of modes were supported.