Skip to content

Add data for timeline plugin documentation.#1

Merged
Conengmo merged 2 commits into
python-visualization:mainfrom
hansthen:add_timeline_example_data
Apr 4, 2024
Merged

Add data for timeline plugin documentation.#1
Conengmo merged 2 commits into
python-visualization:mainfrom
hansthen:add_timeline_example_data

Conversation

@hansthen

@hansthen hansthen commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

Add historical country borders to the example data.

@Conengmo Conengmo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file content seems not right, it's html instead of geojson

@Conengmo

Conengmo commented Apr 3, 2024

Copy link
Copy Markdown
Member

@hansthen so sorry to stall this some more :) but that file is 12MB. We will run it in all our CI, so that does count up. Do you think it's possible to slice that file in some way so it's not as large, but still serves our example purpose?

@hansthen hansthen force-pushed the add_timeline_example_data branch from b59aa62 to 5719ae4 Compare April 3, 2024 14:53
@Conengmo

Conengmo commented Apr 3, 2024

Copy link
Copy Markdown
Member

That works :) maybe also minify it so we don't include unnecessary whitespace?

@hansthen hansthen requested a review from Conengmo April 3, 2024 21:43
@Conengmo Conengmo merged commit 0fa6543 into python-visualization:main Apr 4, 2024
@Conengmo

Conengmo commented Apr 4, 2024

Copy link
Copy Markdown
Member

Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants