Skip to content

refactor(build_environment): add sdist_root_dir and req to BuildEnvironment#1265

Merged
mergify[bot] merged 1 commit into
python-wheel-build:mainfrom
tiran:build-env-sdist-root-dir
Jul 24, 2026
Merged

refactor(build_environment): add sdist_root_dir and req to BuildEnvironment#1265
mergify[bot] merged 1 commit into
python-wheel-build:mainfrom
tiran:build-env-sdist-root-dir

Conversation

@tiran

@tiran tiran commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Pull Request Description

What

Replace the generic parent_dir parameter with sdist_root_dir and req so that BuildEnvironment has the context it needs for future sandboxing and environment filtering. All arguments are now keyword-only and follow the common ctx, req, sdist_root_dir order.

Why

Part of the sandboxing proposal.

See: #1019

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@tiran, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 36760866-d841-4956-b087-b33eeacbefc4

📥 Commits

Reviewing files that changed from the base of the PR and between 973c9e4 and 254e2bf.

📒 Files selected for processing (7)
  • src/fromager/bootstrapper/_prepare_source.py
  • src/fromager/build_environment.py
  • src/fromager/commands/step.py
  • tests/test_bootstrapper_iterative.py
  • tests/test_dependencies.py
  • tests/test_packagesettings.py
  • tests/test_wheels.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify mergify Bot added the ci label Jul 24, 2026
@tiran
tiran marked this pull request as ready for review July 24, 2026 07:42
@tiran
tiran requested a review from a team as a code owner July 24, 2026 07:42
@tiran
tiran force-pushed the build-env-sdist-root-dir branch from e69833f to 6ef4d68 Compare July 24, 2026 07:47
@rd4398
rd4398 requested a review from smoparth July 24, 2026 13:06
@rd4398 rd4398 changed the title refactor(build_environment): add sdist_root_dir and req to BuildEnvironment` refactor(build_environment): add sdist_root_dir and req to BuildEnvironment Jul 24, 2026

@rd4398 rd4398 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I have left a non blocking comment

Comment thread src/fromager/build_environment.py Outdated
…ildEnvironment`

Replace the generic `parent_dir` parameter with `sdist_root_dir` and
`req` so that `BuildEnvironment` has the context it needs for future
sandboxing and environment filtering. All arguments are now
keyword-only and follow the common `ctx, req, sdist_root_dir` order.

Part of the sandboxing proposal.

See: python-wheel-build#1019
Co-Authored-By: Claude <claude@anthropic.com>
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran
tiran force-pushed the build-env-sdist-root-dir branch from 6ef4d68 to 254e2bf Compare July 24, 2026 14:46
@tiran
tiran requested a review from rd4398 July 24, 2026 14:52

@rd4398 rd4398 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I am moving forward and approving this
cc @LalatenduMohanty @smoparth

@mergify
mergify Bot merged commit d249228 into python-wheel-build:main Jul 24, 2026
39 checks passed
@mergify

mergify Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants