Skip to content

feat(build_environment): Include abiflags in path#1269

Draft
tiran wants to merge 2 commits into
python-wheel-build:mainfrom
tiran:free-threading-abi
Draft

feat(build_environment): Include abiflags in path#1269
tiran wants to merge 2 commits into
python-wheel-build:mainfrom
tiran:free-threading-abi

Conversation

@tiran

@tiran tiran commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Pull Request Description

What

Include abiflags in build env path for free-threading (nogil) Python interpreter.

Why

Python 3.14 and 3.14t have different ABIs and need separate build environments

tiran and others added 2 commits July 24, 2026 15:52
…ildEnvironment`

Replace the generic `parent_dir` parameter with `sdist_root_dir` and
`req` so that `BuildEnvironment` has the context it needs for future
sandboxing and environment filtering. All arguments are now
keyword-only and follow the common `ctx, req, sdist_root_dir` order.

Part of the sandboxing proposal.

See: python-wheel-build#1019
Co-Authored-By: Claude <claude@anthropic.com>
Signed-off-by: Christian Heimes <cheimes@redhat.com>
Include abiflags in build env path for free-threading (nogil) Python
interpreter. Python 3.14 and 3.14t have different ABIs and need separate
build environments.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7f3063b6-a3f4-43c4-a04c-4a99f8444484

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify mergify Bot added the ci label Jul 24, 2026
@mergify

mergify Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.
@tiran please rebase your branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant