Skip to content

cleanup(bootstrapper): remove unused logger from _types.py#1275

Open
rd4398 wants to merge 1 commit into
python-wheel-build:mainfrom
rd4398:cleanup/remove-unused-logger-types
Open

cleanup(bootstrapper): remove unused logger from _types.py#1275
rd4398 wants to merge 1 commit into
python-wheel-build:mainfrom
rd4398:cleanup/remove-unused-logger-types

Conversation

@rd4398

@rd4398 rd4398 commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

The logging import and logger definition were carried over when types were extracted from the monolithic bootstrapper.py into _types.py in #1226 but are never used.

Closes: #1245

The `logging` import and `logger` definition were carried over when
types were extracted from the monolithic `bootstrapper.py` into
`_types.py` in python-wheel-build#1226 but are never used.

Co-Authored-By: Claude <claude@anthropic.com>
Closes: python-wheel-build#1245
Signed-off-by: Rohan Devasthale <rdevasth@redhat.com>
@rd4398
rd4398 requested a review from a team as a code owner July 25, 2026 15:31
@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 7260bbba-9654-425b-99c2-1c125ef93916

📥 Commits

Reviewing files that changed from the base of the PR and between d249228 and 4ecac09.

📒 Files selected for processing (1)
  • src/fromager/bootstrapper/_types.py
💤 Files with no reviewable changes (1)
  • src/fromager/bootstrapper/_types.py

📝 Walkthrough

Walkthrough

Removed the unused logging import and module-level logger declaration from src/fromager/bootstrapper/_types.py. The module remains focused on bootstrap artifact and phase type definitions.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: removing an unused logger from _types.py.
Description check ✅ Passed The description matches the change and linked issue by noting the unused logging import and logger were removed.
Linked Issues check ✅ Passed The PR removes both import logging and logger = logging.getLogger(__name__) from _types.py, satisfying #1245.
Out of Scope Changes check ✅ Passed No unrelated code changes are indicated; the PR is limited to removing the unused logger setup in _types.py.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cleanup(bootstrapper): remove unused logger from _types.py

1 participant