Skip to content

Apply 'awaiting core review' label to new core-dev PRs#158

Merged
brettcannon merged 2 commits into
python:masterfrom
lysnikolaou:core-dev-pr-label
Mar 21, 2019
Merged

Apply 'awaiting core review' label to new core-dev PRs#158
brettcannon merged 2 commits into
python:masterfrom
lysnikolaou:core-dev-pr-label

Conversation

@lysnikolaou

Copy link
Copy Markdown
Member

Related to issue #157.

@codecov

codecov Bot commented Mar 20, 2019

Copy link
Copy Markdown

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #158   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          20     20           
  Lines        1529   1529           
  Branches       86     86           
=====================================
  Hits         1529   1529
Impacted Files Coverage Δ
bedevere/stage.py 100% <100%> (ø) ⬆️
tests/test_stage.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d1c4b...64b97ff. Read the comment docs.

@brettcannon brettcannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docstring for opened_pr() is now out-of-date. Update that and the PR will LGTM!

@lysnikolaou

lysnikolaou commented Mar 21, 2019

Copy link
Copy Markdown
Member Author

@brettcannon Done!

@brettcannon
brettcannon merged commit 5384b63 into python:master Mar 21, 2019
@brettcannon

Copy link
Copy Markdown
Member

@lysnikolaou thanks!

@lysnikolaou
lysnikolaou deleted the core-dev-pr-label branch March 21, 2019 22:18
potomak added a commit to potomak/bedevere that referenced this pull request Jul 28, 2019
After python#158 has been merged, the state machine graph was out of date.
This update fixes the transition from "New PR" for core developers to
"Awaiting core review" instead of "Awaiting merge".
brettcannon pushed a commit that referenced this pull request Aug 2, 2019
After #158 has been merged, the state machine graph was out of date.
This update fixes the transition from "New PR" for core developers to
"Awaiting core review" instead of "Awaiting merge".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants