Skip to content

bpo-42336: Updated PCbuild batch files#221

Merged
pablogsal merged 1 commit into
python:masterfrom
zooba:bpo-42336
Nov 18, 2020
Merged

bpo-42336: Updated PCbuild batch files#221
pablogsal merged 1 commit into
python:masterfrom
zooba:bpo-42336

Conversation

@zooba

@zooba zooba commented Nov 16, 2020

Copy link
Copy Markdown
Member

The default settings in the PCbuild/*.bat files are being updated, so we'll need this update as well to maintain buildbots.

@zooba

zooba commented Nov 16, 2020

Copy link
Copy Markdown
Member Author

I'm not entirely sure how best to schedule the merges... I guess we should merge this one first and let builds fail until the other one is merged? Or maybe it makes more sense to go the other way around. (They'll fail because I've also switched these to the more consistent -p flag, but I guess that could be split out into a later PR to try and avoid any breakage at all? But if we merge them all at the same time, no big deal, right?)

@pablogsal

Copy link
Copy Markdown
Member

But if we merge them all at the same time, no big deal, right?)

Yeah, the worst case, if we do two PRs, is that 1 build will fail but all others will succeed and you will get some noise in the breaking PR from the reporter. If you are able to merge botch changes into the same PR then everything should be green. I will be keeping an eye on the build bots in case we need to do something else but as long as we know about it, I would recommend to preceded in the way is more comfortable for you :)

@pablogsal

Copy link
Copy Markdown
Member

I think you can land in this repo, but otherwise, ping me and I will land it

@zooba

zooba commented Nov 16, 2020

Copy link
Copy Markdown
Member Author

I can't merge here, so go ahead whenever you like and I'll merge python/cpython#23275 and keep an eye on the buildbots. Looks like they're not busy now, so hopefully it'll be smooth enough.

@vstinner

Copy link
Copy Markdown
Member

The default settings in the PCbuild/*.bat files are being updated, so we'll need this update as well to maintain buildbots.

Do you plan to update 3.8 and 3.9 as well? 3.9 yes according to the labels on your PR.

@vstinner

Copy link
Copy Markdown
Member

@pablogsal @zware: it seems like we still support 3.7 in buildbots, no?

@zooba

zooba commented Nov 16, 2020

Copy link
Copy Markdown
Member Author

I wasn't going to touch 3.7. Guess I can do 3.8, but I'll customise the patch to not change the default build (since the default download for 3.8 was 32-bit).

@vstinner

Copy link
Copy Markdown
Member

I'm asking if this PR should run a differerent command depending on the branch.

@zooba

zooba commented Nov 16, 2020

Copy link
Copy Markdown
Member Author

It could... how do I make it do that?

@zware

zware commented Nov 16, 2020

Copy link
Copy Markdown
Member

@pablogsal @zware: it seems like we still support 3.7 in buildbots, no?

I think we could remove 3.7 now, if @ned-deily is ok with it.

I'm asking if this PR should run a differerent command depending on the branch.

I'd rather avoid that if we can, but it is an option.

@pablogsal

Copy link
Copy Markdown
Member

I'd rather avoid that if we can, but it is an option.

I don't see other way if we are going to use options that are not available on 3.8 and 3.7

@zooba

zooba commented Nov 16, 2020

Copy link
Copy Markdown
Member Author

python/cpython#23325 will add the option on 3.8 without changing the defaults. It can probably backport safely to 3.7, too

@ned-deily

Copy link
Copy Markdown
Member

It can probably backport safely to 3.7, too

If you feel up to doing that, I would be ok with merging to 3.7 (with the default as 32-bit). If the 3.7 buildbots are not taking needed resources needed by other branches, it would be good to keep buildbots for at least the most important platforms available to test security fixes for the branch.

@zooba

zooba commented Nov 17, 2020

Copy link
Copy Markdown
Member Author

"Feel up to" means adding the tag and then pinging you to hit merge (I hope) ;)

I'm ready again to make this happen if someone merges the config.

@pablogsal pablogsal merged commit db57e24 into python:master Nov 18, 2020
@pablogsal

Copy link
Copy Markdown
Member

I'm ready again to make this happen if someone merges the config.

Granted ✨

@zooba zooba deleted the bpo-42336 branch November 18, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants