Skip to content

GH-68: git clone failures mark the build as WARNING #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 1 commit into from
Dec 2, 2018
Merged

GH-68: git clone failures mark the build as WARNING #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion master/custom/steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
import re

from buildbot.steps.shell import ShellCommand, Test as BaseTest
from buildbot.steps.source.git import Git as _Git


class Git(_Git):
# GH-68: If "git clone" fails, mark the whole build as WARNING
# (warnOnFailure), not as "FAILURE" (flunkOnFailure)
haltOnFailure = True
flunkOnFailure = False
warnOnFailure = True


class Test(BaseTest):
Expand Down Expand Up @@ -44,7 +53,7 @@ class Test(BaseTest):

# if tests have warnings, mark the overall build as WARNINGS (orange)
warnOnWarnings = True

# 3 hours should be enough even for refleak builds.
maxTime = 3 * 60 * 60
# Give SIGTERM 30 seconds to shut things down before SIGKILL.
Expand Down
2 changes: 1 addition & 1 deletion master/master.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ from buildbot.schedulers.forcesched import ForceScheduler
from buildbot.schedulers.timed import Nightly
from buildbot.plugins import reporters, util
from buildbot import locks
from buildbot.steps.source.git import Git

sys.path.append(os.path.dirname(__file__)) # noqa: E402

Expand All @@ -47,6 +46,7 @@ from custom.factories import (
Windows64ReleaseBuild,
)
from custom.pr_reporter import GitHubPullRequestReporter
from custom.steps import Git

# sensitive and/or instance-specific values
try:
Expand Down