Skip to content

Update builder tiers to match PEP 11 - #792

Open
StanFromIreland wants to merge 2 commits into
python:mainfrom
StanFromIreland:pep-11-update
Open

StanFromIreland wants to merge 2 commits into
python:mainfrom
StanFromIreland:pep-11-update

Conversation

@StanFromIreland

Copy link
Copy Markdown
Member

This makes the tiers consistent with those specified by PEP 11 (unfortunately some changes are not quite correct for older branches, as tiers aren't specific per branch). Also, technically it isn't a complete update as RISC-V is left to #791 (since that includes an additional change from unstable to stable).

Comment thread master/custom/builders.py
Comment on lines +346 to +347
# WASI (3.11 and 3.12 only, where WASI was tier 3)
("wasm32-wasi Non-Debug", "bcannon-wasi", Wasm32WasiCrossBuild),

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistent with:

# The non-debug WASI buildbot is meant for 3.11 and 3.12 only.
# Don't use it on PRs; it's tier 3 only and getting it to
# work on PRs against `main` is too much work.
self.branches = {BRANCHES[3, 11], BRANCHES[3, 12]}

@vstinner

Copy link
Copy Markdown
Member

Oh, I merged your RISC-V change which introduced a conflict in this change. I reviewed the RISC-V first, but it would be be better to merge this change first since it's way later. Well, too late :-)

@StanFromIreland

Copy link
Copy Markdown
Member Author

No worries, there would be some conflicts in either order. Fixed now. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants