Wrap some multi-line macros in ``do { ... } while(0)`` in ``symtable.c``

[picnixz]

Feature or enhancement

Proposal:

While I was implementing #119976, I observed that some macros are not guarded against possible constructions because their content is only wrapped in {} but not in the classical do { ... } while(0) construction.

For instance, the current VISIT macro sometimes requires the semi-colon and sometimes not depending on how it is used, which I find a bit confusing. I think it's preferrable to always require to add the ;.

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs

• gh-119981: use do { ... } while(0) in some multi-line macros #119982

[sobolevn]

There are similar patterns in compile.c, maybe it is also worth taking a look? 🤔

[picnixz]

Yes, that's a good idea. Since I was going offline in a few minutes, could you either close this issue or edit the title so that we can perhaps track other files?

[sobolevn]

I prefer to open new ones for each piece of work :)
Thanks again!