Multiple tests fail with `-OO`

[sobolevn]

When you run ./python.exe -OO -m test MODULE_NAME at least these ones fail:

8 tests failed:
    test.test_pydoc.test_pydoc test_ast test_builtin test_compile
    test_dis test_generated_cases test_interpreters test_remote_pdb

In my opinion it would be easier to contribute one test fix at a time. Rebases and reviews will be simplier. So, contributions are welcome!

I will create a single PR just to show how this can be solved for new contributors.

• test.test_pydoc.test_pydoc
• test_ast
• test_builtin, @sobolevn
• test_compile
• test_dis
• test_generated_cases
• test_interpreters
• test_remote_pdb

Linked PRs

• gh-136438: Make sure test_builtins pass with all optimization levels #136474
• gh-136438: Make sure test_compile pass with all optimization levels #136478
• gh-136438: Make sure test.test_pydoc.test_pydoc pass with all optimization levels #136479
• [3.14] gh-136438: Make sure test_builtins pass with all optimization levels (GH-136474) #136496
• gh-136438: Make sure test_interpreters pass with all optimization levels #136499
• [3.13] gh-136438: Make sure test_builtins pass with all optimization levels (GH-136474) #136502
• gh-136438: Make sure test_dis pass with all optimization levels #136593
• gh-136438: Make sure test_generated_cases pass with all optimization levels #136594
• gh-136438: Make sure test_ast pass with all optimization levels #136596
• gh-136438: Make sure test_remote_pdb pass with all optimization levels #136788
• [3.14] gh-136438: Make sure test_remote_pdb pass with all optimization levels (GH-136788) #136855

[gvanrossum]

Does anybody actually care about running the tests with -OO?

[sobolevn]

@gvanrossum we have a lot of special-casing around this feature in tests. I guess it is used by someone, otherwise, it would not be here at all.

My usecase was to check that subinterpreters don't have any magic assert statements that are required as the part of the main logic. -OO allows me to disable them and run tests again to be sure that everything still works.

I am not sure that this is a common use-case, though.

[kodsurfer]

@sobolevn should we wait your example PR or find another way?

[sobolevn]

@kodsurfer there's no rush :)

Let's first discuss whether this is worth doing, because clearly Guido has more context than me. If this is a waste of time, I will just close the issue.

[picnixz]

FTR, I use -OO to remove expensive assertions when doing numerical optimizations so I would be interested in features working even in -OO.

Now, I don't think it's useful to run tests in -OO but it is useful to know that what we test works in -OO as well.

[gvanrossum]

I don't actually have more context except that given what -OO does I would expect failures and think nothing of it (I have no desire to fix any of these).

Moreover, I presume we're not going to make CI even slower or more expensive by running all tests with all three "optimization" levels, so even if you fix the failures above, there won't be any guarantee that in the future other tests won't break with -O or -OO.

You could think of -OO as an unsupported platform.

Then again, if a particular test failure with -OO bothers you and is easy to fix I won't stop you. It just doesn't feel like an important thing to care about.