Bug report
Bug description:
When the IDLE shell namespace has a non-iterable __all__ (for example __all__ = None, an easy typo), pressing Tab for module-name completion at an empty prefix raises an uncaught TypeError instead of showing completions.
autocomplete.AutoComplete.fetch_completions handles the ATTRS empty-prefix case with sorted(eval("__all__", namespace)) and no guard, while the sibling non-empty-prefix branch already wraps the equivalent sorted(entity.__all__) in try/except and returns empty lists on failure. Only the empty-prefix branch is affected.
Reproduction in the IDLE shell:
>>> __all__ = None
>>> # press Tab at an empty prefix
TypeError: 'NoneType' object is not iterable
A deterministic regression test that drives fetch_completions with a patched __main__.__all__ is included in the linked PR.
Suggested fix: guard the empty-prefix branch the same way the sibling branch is guarded, returning empty completion lists when __all__ cannot be evaluated or sorted.
CPython versions tested on:
3.16, CPython main branch
Operating systems tested on:
macOS
Linked PRs
Bug report
Bug description:
When the IDLE shell namespace has a non-iterable
__all__(for example__all__ = None, an easy typo), pressing Tab for module-name completion at an empty prefix raises an uncaughtTypeErrorinstead of showing completions.autocomplete.AutoComplete.fetch_completionshandles theATTRSempty-prefix case withsorted(eval("__all__", namespace))and no guard, while the sibling non-empty-prefix branch already wraps the equivalentsorted(entity.__all__)intry/exceptand returns empty lists on failure. Only the empty-prefix branch is affected.Reproduction in the IDLE shell:
A deterministic regression test that drives
fetch_completionswith a patched__main__.__all__is included in the linked PR.Suggested fix: guard the empty-prefix branch the same way the sibling branch is guarded, returning empty completion lists when
__all__cannot be evaluated or sorted.CPython versions tested on:
3.16, CPython main branch
Operating systems tested on:
macOS
Linked PRs