2.3a2 build fails under IRIX 6.5

[rwgk]

BPO	690012
Nosy	@gvanrossum
Files	py23a2_irix_configure_make_log.txt setup.diff: patch to catch all errors when building modules iconv.diff: updated patch 2

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2003-02-28.17:35:41.000>
created_at = <Date 2003-02-20.12:36:57.000>
labels = ['build']
title = '2.3a2 build fails under IRIX 6.5'
updated_at = <Date 2003-02-28.17:35:41.000>
user = 'https://bugs.python.org/rwgk'

bugs.python.org fields:

activity = <Date 2003-02-28.17:35:41.000>
actor = 'nnorwitz'
assignee = 'nnorwitz'
closed = True
closed_date = None
closer = None
components = ['Build']
creation = <Date 2003-02-20.12:36:57.000>
creator = 'rwgk'
dependencies = []
files = ['793', '794', '795']
hgrepos = []
issue_num = 690012
keywords = []
message_count = 9.0
messages = ['14686', '14687', '14688', '14689', '14690', '14691', '14692', '14693', '14694']
nosy_count = 3.0
nosy_names = ['gvanrossum', 'nnorwitz', 'rwgk']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue690012'
versions = ['Python 2.3']

[rwgk]

Using the latest Python 2.3a2 release
./configure; make
fails on this platform:
IRIX rattler 6.5 10120734 IP32
See attached logs.

I've also tried configure --disable-ipv6, but the result is
the same.

The previous 2.3a1 release works without a problem
on the exact same machine.

[nnorwitz]

Logged In: YES
user_id=33168

In order to get the build to proceed, you can change line
210 of setup.py from:

        except ImportError, why:
to:
        except (ImportError, RuntimeError), why:

This is just before:
self.announce('*** WARNING: renaming "%s" since
importing it' ...)

[nnorwitz]

Logged In: YES
user_id=33168

Guido, I agree with your comment on python-dev that the fix
below is not best. Attached is a patch which catches all
exceptions, and changes the warning message appropriately.
There are 2 other issues.

1. I don't know why the if 1: is there, should that be removed?
2. During a normal build these warning messages aren't
   printed, shouldn't they be?

[gvanrossum]

Logged In: YES
user_id=6380

• I think the renaming shouldn't happen at all unless the
  exception is ImportError.

• The if 1 can then be replaced by if isinstance(why,
  ImportError).

• The message in the else branch should be changed to
  include the exception name.

• I thought I fixed the logging level of these messages, by
  adding "level=3", in one of the first checkins after
  releasing 2.3a2. But possibly I may have botched that. Can
  you check that they really aren't printed?

[gvanrossum]

Logged In: YES
user_id=6380

(Note, there are other compilation errors in the attached logs.)

[nnorwitz]

Logged In: YES
user_id=33168

Updated patch for review (updated patch 2). Guido, can you
review (it's short)?

• renaming only happens on ImportError
• if 1 is removed in favor of checking for ImportError
• there was no problem with the warning being printed
  (level is in there), I must have been daydreaming.

I reverted the change in iconv to again raise a RuntimeError
instead of ImportError. The make will continue with the
warning printed. This will hopefully get us over the worst
problems with iconv.

[gvanrossum]

Logged In: YES
user_id=6380

Yes, looks good.

[nnorwitz]

Logged In: YES
user_id=33168

Checked in as:

setup.py 1.152
Modules/_iconv_codec.c 1.14Misc/NEWS 1.681

[nnorwitz]

Logged In: YES
user_id=33168

Ralf, could you test from CVS to make sure everything is ok.
The fix was general, but I'd like to make sure beta1 is in
better shape. Thanks.