test_grp

[mjbrands]

BPO	36017
Nosy	@MatzeB
PRs	bpo-36017: Improve test_grp.test_errors for (big) LDAP directories #19033

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = None
created_at = <Date 2019-02-17.21:15:28.125>
labels = ['3.7', 'type-bug', 'tests']
title = 'test_grp'
updated_at = <Date 2020-03-16.21:43:29.669>
user = 'https://bugs.python.org/mjbrands'

bugs.python.org fields:

activity = <Date 2020-03-16.21:43:29.669>
actor = 'Matthias Braun'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Tests']
creation = <Date 2019-02-17.21:15:28.125>
creator = 'mjbrands'
dependencies = []
files = []
hgrepos = []
issue_num = 36017
keywords = ['patch']
message_count = 1.0
messages = ['335788']
nosy_count = 2.0
nosy_names = ['mjbrands', 'Matthias Braun']
pr_nums = ['19033']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue36017'
versions = ['Python 3.7']

Linked PRs

• gh-80198: Improve test_pwd and test_grp #150380
• [3.15] gh-80198: Improve test_pwd and test_grp (GH-150380) #150398
• [3.14] gh-80198: Improve test_pwd and test_grp (GH-150380) (GH-150398) #150422
• [3.13] gh-80198: Improve test_pwd and test_grp (GH-150380) (GH-150398) #150423

[mjbrands]

# Choose a non-existent gid.
        fakegid = 4127
        while fakegid in bygids:
            fakegid = (fakegid * 3) % 0x10000

        self.assertRaises(KeyError, grp.getgrgid, fakegid)

When a Linux system is configured to use LDAP for user and group information, there is no guarantee that grp.getgrall will actually return a complete list of all configured groups.

In my case, grp.getgrall only returns 58 groups, while there are actually tens of thousands of groups (every user has their own group, which generally only has one member). The groups return by grp.getgrall are the 'system' groups (things like daemon, wheel, etc). In our case 4127 is an existing group and grp.getgrid can query information for it (and does not thrown the expected KeyError, since it is a valid group).

Perhaps this unit test should not rely on getgrall, but relying on getgrid on the test for getgrid itself is also problematic.

I have seen this LDAP setup, where getgrall does not return the full set of groups, at two different parties with lots of users (and Novell eDirectory).