Skip to content

bpo-34011: Fix the construction of subprocess.CalledProcessError in test_venv#10400

Merged
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo34011
Nov 7, 2018
Merged

bpo-34011: Fix the construction of subprocess.CalledProcessError in test_venv#10400
pablogsal merged 1 commit into
python:masterfrom
pablogsal:bpo34011

Conversation

@pablogsal

@pablogsal pablogsal commented Nov 7, 2018

Copy link
Copy Markdown
Member

@pablogsal pablogsal self-assigned this Nov 7, 2018
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting merge labels Nov 7, 2018
@pablogsal pablogsal merged commit b939250 into python:master Nov 7, 2018
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@pablogsal pablogsal deleted the bpo34011 branch November 7, 2018 22:21
@bedevere-bot

Copy link
Copy Markdown

GH-10401 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 7, 2018
…ythonGH-10400)

The constructor of subprocess.CalledProcessError in the check_output function had an extra None in it.
(cherry picked from commit b939250)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 7, 2018
…ythonGH-10400)

The constructor of subprocess.CalledProcessError in the check_output function had an extra None in it.
(cherry picked from commit b939250)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-10402 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request Nov 7, 2018
…H-10400)

The constructor of subprocess.CalledProcessError in the check_output function had an extra None in it.
(cherry picked from commit b939250)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request Nov 7, 2018
…H-10400)

The constructor of subprocess.CalledProcessError in the check_output function had an extra None in it.
(cherry picked from commit b939250)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants