bpo-35194: Fix a wrong constant in cp932 codec#10420
Merged
Merged
Conversation
This typo doesn't affect the result because wrong bits are discarded on implicit conversion to unsigned char, but it trips UBSan with -fsanitize=implicit-integer-truncation.
Contributor
Author
|
The test exists. |
methane
approved these changes
Nov 9, 2018
methane
left a comment
methane
left a comment
Member
There was a problem hiding this comment.
I think this fix is obvious enough.
Contributor
|
Thanks @izbyshev for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-10423 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 9, 2018
This typo doesn't affect the result because wrong bits are discarded on implicit conversion to unsigned char, but it trips UBSan with -fsanitize=implicit-integer-truncation. https://bugs.python.org/issue35194 (cherry picked from commit 7a69cf4) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
|
GH-10424 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 9, 2018
This typo doesn't affect the result because wrong bits are discarded on implicit conversion to unsigned char, but it trips UBSan with -fsanitize=implicit-integer-truncation. https://bugs.python.org/issue35194 (cherry picked from commit 7a69cf4) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
Contributor
|
Thanks @izbyshev for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7. |
Contributor
|
Sorry, @izbyshev, I could not cleanly backport this to |
miss-islington
added a commit
that referenced
this pull request
Nov 9, 2018
This typo doesn't affect the result because wrong bits are discarded on implicit conversion to unsigned char, but it trips UBSan with -fsanitize=implicit-integer-truncation. https://bugs.python.org/issue35194 (cherry picked from commit 7a69cf4) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
miss-islington
added a commit
that referenced
this pull request
Nov 9, 2018
This typo doesn't affect the result because wrong bits are discarded on implicit conversion to unsigned char, but it trips UBSan with -fsanitize=implicit-integer-truncation. https://bugs.python.org/issue35194 (cherry picked from commit 7a69cf4) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
izbyshev
pushed a commit
to izbyshev/cpython
that referenced
this pull request
Nov 9, 2018
This typo doesn't affect the result because wrong bits are discarded on implicit conversion to unsigned char, but it trips UBSan with -fsanitize=implicit-integer-truncation. https://bugs.python.org/issue35194. (cherry picked from commit 7a69cf4) Co-authored-by: Alexey Izbyshev <izbyshev@ispras.ru>
|
GH-10433 is a backport of this pull request to the 2.7 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This typo doesn't affect the result because wrong bits are discarded
on implicit conversion to unsigned char, but it trips UBSan
with -fsanitize=implicit-integer-truncation.
https://bugs.python.org/issue35194