gh-107955 Remove old comment about increasing the reference count in usage of Py_None#107993
Conversation
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
What to put for https://devguide.python.org/core-developers/committing/index.html#updating-news-and-what-s-new-in-python? Is relevant here or no? I read "If a change is a fix (or other adjustment) to an earlier unreleased change and the original NEWS entry remains valid, then no additional entry is needed" and I am not sure. Also, how to make title format for PyNone look like the title for 107955? |
If you only modify the document or comments, you usually do not need a News entry. Please wait for others to add
I guess what you want is to convert this variable to markdown format? Just use `Py_None`. |
|
Thanks for the PR, @brandonardenwalli! |
|
I think, it should be backported to 3.12 branch |
Not worth the churn, in my opinion -- we should generally only backport docs fixes and bugfixes, and this doesn't fix a user-visible bug :) |
|
But thanks for the PR @brandonardenwalli -- congrats on your first contribution! |
The original issue was introduced 3.12 branch, that's why I thinking about backporting to 3.12 =) |
I have a little bit of problem making change from local machine, so I do this on GitHub Codespaces, I hope it is okay.
If I make mistake, please do make fix for it :)
Also, the Codespaces starting took a while for me, around 10 minutes. Is this normal? I feel like I may have done something wrong to make it so slow?
Also, in the comment for this Pull Request, it say "If this is a backport PR (PR made against branches other than
main)," and I think this is not? Let me know if otherwise. Thanks!Py_None#107955