Skip to content

gh-107955 Remove old comment about increasing the reference count in usage of Py_None#107993

Merged
kumaraditya303 merged 1 commit into
python:mainfrom
brandonardenwalli:remove-comment
Aug 16, 2023
Merged

gh-107955 Remove old comment about increasing the reference count in usage of Py_None#107993
kumaraditya303 merged 1 commit into
python:mainfrom
brandonardenwalli:remove-comment

Conversation

@brandonardenwalli

@brandonardenwalli brandonardenwalli commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

I have a little bit of problem making change from local machine, so I do this on GitHub Codespaces, I hope it is okay.

If I make mistake, please do make fix for it :)

Also, the Codespaces starting took a while for me, around 10 minutes. Is this normal? I feel like I may have done something wrong to make it so slow?

Also, in the comment for this Pull Request, it say "If this is a backport PR (PR made against branches other than main)," and I think this is not? Let me know if otherwise. Thanks!

@ghost

ghost commented Aug 16, 2023

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@brandonardenwalli

brandonardenwalli commented Aug 16, 2023

Copy link
Copy Markdown
Contributor Author

What to put for https://devguide.python.org/core-developers/committing/index.html#updating-news-and-what-s-new-in-python? Is relevant here or no? I read "If a change is a fix (or other adjustment) to an earlier unreleased change and the original NEWS entry remains valid, then no additional entry is needed" and I am not sure.

Also, how to make title format for PyNone look like the title for 107955?

@CharlieZhao95

Copy link
Copy Markdown
Contributor

Is relevant here or no?

If you only modify the document or comments, you usually do not need a News entry. Please wait for others to add skip news label.

Also, how to make title format for PyNone look like the title for 107955?

I guess what you want is to convert this variable to markdown format? Just use `Py_None`.

@Eclips4

Eclips4 commented Aug 16, 2023

Copy link
Copy Markdown
Member

Thanks for the PR, @brandonardenwalli!

@Eclips4

Eclips4 commented Aug 16, 2023

Copy link
Copy Markdown
Member

I think, it should be backported to 3.12 branch

@AlexWaygood

Copy link
Copy Markdown
Member

I think, it should be backported to 3.12 branch

Not worth the churn, in my opinion -- we should generally only backport docs fixes and bugfixes, and this doesn't fix a user-visible bug :)

@AlexWaygood

Copy link
Copy Markdown
Member

But thanks for the PR @brandonardenwalli -- congrats on your first contribution!

@Eclips4

Eclips4 commented Aug 16, 2023

Copy link
Copy Markdown
Member

I think, it should be backported to 3.12 branch

Not worth the churn, in my opinion -- we should generally only backport docs fixes and bugfixes, and this doesn't fix a user-visible bug :)

The original issue was introduced 3.12 branch, that's why I thinking about backporting to 3.12 =)
But, I agree, this fix is not user-visible. So, let's close the attached issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants