bpo-5430: Preservation LF, CR in IMAP4 append method.#10901
bpo-5430: Preservation LF, CR in IMAP4 append method.#10901hobbestigrou wants to merge 1 commit into
Conversation
Preserve LF, CR in the append method. Co-authored-by: Ron DuPlain <ron.duplain@gmail.com>
JulienPalard
left a comment
JulienPalard
left a comment
There was a problem hiding this comment.
Hi Natal! This PR is in complete contradiction with: https://bugs.python.org/issue723962
So I think it needs more discussion on the issue before being merged, and will probably needs to be modified before being merged (though the "Request changes").
| br'"') | ||
| # Literal is no longer used; kept for backward compatibility. | ||
| Literal = re.compile(br'.*{(?P<size>\d+)}$', re.ASCII) | ||
| MapCRLF = re.compile(br'\r\n|\r|\n') |
There was a problem hiding this comment.
In any cases, please don't remove it, one may be using it, please do as the previous Literal one, keep it but state it's no longer used and kept for backward compatibility.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Changes were requested over two years ago by a core dev, but have not been applied. I am therefore closing this PR. @hobbestigrou, if you're still interested in working on this issue, feel free to open a new PR. Alternatively, ping me and I'll happily reopen the PR. Thanks! 🙂 |
5 participants
Preserve LF, CR in the append method.
Co-authored-by: Ron DuPlain ron.duplain@gmail.com
https://bugs.python.org/issue5430