Skip to content

bpo-35452: Make PySys_HasWarnOptions() never raising an exception.#11075

Merged
serhiy-storchaka merged 2 commits into
python:masterfrom
serhiy-storchaka:PySys_HasWarnOptions
Dec 10, 2018
Merged

bpo-35452: Make PySys_HasWarnOptions() never raising an exception.#11075
serhiy-storchaka merged 2 commits into
python:masterfrom
serhiy-storchaka:PySys_HasWarnOptions

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Dec 10, 2018

Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just have a minor suggestion.

Comment thread Python/sysmodule.c Outdated
Co-Authored-By: serhiy-storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka merged commit dffccc6 into python:master Dec 10, 2018
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the PySys_HasWarnOptions branch December 10, 2018 11:50
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 10, 2018
…ythonGH-11075)

(cherry picked from commit dffccc6)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-11076 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Dec 10, 2018
…H-11075)

(cherry picked from commit dffccc6)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants