Skip to content

bpo-35502: Fix reference leaks in ElementTree.TreeBuilder.#11170

Merged
serhiy-storchaka merged 2 commits into
python:masterfrom
serhiy-storchaka:etree-treebuilder-leak
Dec 18, 2018
Merged

bpo-35502: Fix reference leaks in ElementTree.TreeBuilder.#11170
serhiy-storchaka merged 2 commits into
python:masterfrom
serhiy-storchaka:etree-treebuilder-leak

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Dec 14, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.7 labels Dec 14, 2018
vstinner
vstinner reviewed Dec 18, 2018
View reviewed changes
Comment thread Lib/test/test_xml_etree_c.py
vstinner
vstinner reviewed Dec 18, 2018
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2018-12-14-23-56-48.bpo-35502.gLHuFS.rst Outdated
@@ -0,0 +1,2 @@
Fixed reference leaks in :class:`xml.etree.ElementTree.TreeBuilder` in case
of unfinished building of the tree.

@vstinner vstinner Dec 18, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that the error is restricted to "unfinished building of the tree", it's more generally caused by syntax errors: https://bugs.python.org/issue35502#msg332051

@serhiy-storchaka

serhiy-storchaka commented Dec 18, 2018

Copy link
Copy Markdown
Member Author

Thank you @vstinner for your review. I tried to address your comments.

vstinner
vstinner approved these changes Dec 18, 2018
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit d2a75c6 into python:master Dec 18, 2018
@miss-islington

miss-islington commented Dec 18, 2018

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the etree-treebuilder-leak branch December 18, 2018 20:29
@bedevere-bot

bedevere-bot commented Dec 18, 2018

Copy link
Copy Markdown

GH-11217 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 18, 2018
@serhiy-storchaka @miss-islington
bpo-35502: Fix reference leaks in ElementTree.TreeBuilder. (pythonGH-…
542733e 
…11170)

(cherry picked from commit d2a75c6)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Dec 18, 2018
@miss-islington @serhiy-storchaka
bpo-35502: Fix reference leaks in ElementTree.TreeBuilder. (GH-11170)
60c919b 
(cherry picked from commit d2a75c6)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni