gh-114713: handle case of an empty string passed to ZoneInfo - #114731
Merged
Conversation
Eclips4
added
needs backport to 3.11
Member
|
I don't think that kind of change is needed in a Also, macOS CI/CD failure is unrelated. I'll restart it later. |
sobolevn
reviewed
Jan 30, 2024
sobolevn
left a comment
sobolevn
left a comment
Member
There was a problem hiding this comment.
I think it makes sense to check for an empty string before if os.path.isabs(path):, isn't it?
sobolevn
reviewed
Jan 30, 2024
Contributor
Author
|
Thank you @sobolevn for the review. I agree with your statements so I rewrote the check |
serhiy-storchaka
added
needs backport to 3.13
Eclips4
approved these changes
Nov 29, 2024
Member
|
@wrongnull do you have a moment to add a NEWS entry? |
Contributor
Author
yeah, I'm going to add it now |
…kq9vZ.rst Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Member
|
@Eclips4 friendly ping :-) |
Eclips4
reviewed
Apr 15, 2025
|
Thanks @wrongnull for the PR, and @Eclips4 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 15, 2025
…oneInfo` (pythonGH-114731) (cherry picked from commit 884df11) Co-authored-by: Bogdan Romanyuk <65823030+wrongnull@users.noreply.github.com> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
|
GH-132563 is a backport of this pull request to the 3.13 branch. |
Eclips4
added a commit
that referenced
this pull request
Apr 15, 2025
…ZoneInfo` (GH-114731) (#132563) gh-114713: Handle case of an empty string passed to `zoneinfo.ZoneInfo` (GH-114731) (cherry picked from commit 884df11) Co-authored-by: Bogdan Romanyuk <65823030+wrongnull@users.noreply.github.com> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com> Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Eclips4
added a commit
to Eclips4/cpython
that referenced
this pull request
May 3, 2025
…neinfo.ZoneInfo` (python#114731)" This reverts commit 884df11.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 3, 2025
Revert "pythongh-114713: Handle case of an empty string passed to `zoneinfo.ZoneInfo` (pythonGH-114731)" This reverts commit 884df11. (cherry picked from commit fe44fc4) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
Revert "pythongh-114713: Handle case of an empty string passed to `zoneinfo.ZoneInfo` (python#114731)" This reverts commit 884df11.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This special case will make the error message less confusing.
''#114713