Skip to content

[3.6] - "Revert bpo-24746: Avoid stripping trailing whitespace in doctest fancy diff (GH-10639)"#11509

Merged
ned-deily merged 1 commit into
3.6from
revert-11477-backport-cbb1645-3.6
Jan 10, 2019
Merged

[3.6] - "Revert bpo-24746: Avoid stripping trailing whitespace in doctest fancy diff (GH-10639)"#11509
ned-deily merged 1 commit into
3.6from
revert-11477-backport-cbb1645-3.6

Conversation

@orsenthil

@orsenthil orsenthil commented Jan 10, 2019

Copy link
Copy Markdown
Member

Reverts #11477

3.6 is in security fixes only mode and the patch merge was a mistake.

https://bugs.python.org/issue24746

@orsenthil orsenthil changed the title Revert "[3.6] bpo-24746: Avoid stripping trailing whitespace in doctest fancy diff (GH-10639)" [3.6] bpo-24746: Avoid stripping trailing whitespace in doctest fancy diff (GH-10639) Jan 10, 2019
@vstinner

Copy link
Copy Markdown
Member

The commit message is confusing. I read it as the fix, whereas it's a revert.

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ned-deily would you mind to merge this change?

@orsenthil orsenthil changed the title [3.6] bpo-24746: Avoid stripping trailing whitespace in doctest fancy diff (GH-10639) [3.6] - "Revert bpo-24746: Avoid stripping trailing whitespace in doctest fancy diff (GH-10639)" Jan 10, 2019
@orsenthil

Copy link
Copy Markdown
Member Author

@vstinner : I changed the title. I just need to "[3.6]" to satisfy the the status check, but I removed the "Revert" and it caused some confusion.

Should we wait for @ned-deily or shall we merge this once the CI goes green? I seem to have the privs to merge this PR.

@vstinner

Copy link
Copy Markdown
Member

Should we wait for @ned-deily or shall we merge this once the CI goes green? I seem to have the privs to merge this PR.

I'm not allowed to merge PRs in the 3.6 branch, the branch is restricted to release managers like @ned-deily.

@ned-deily ned-deily merged commit d09e8ce into 3.6 Jan 10, 2019
@ned-deily

Copy link
Copy Markdown
Member

Thanks all for catching and fixing this. I don't understand how you were able to merge the original PR to 3.6 in the first place unless the branch protection settings had been inadvertently changed and subsequently reset. This is one reason why we want to minimize the number of people with repo administrative privileges.

@zware zware deleted the revert-11477-backport-cbb1645-3.6 branch January 16, 2019 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants