Skip to content

docs: use consistent .append() in dis.rst#115434

Merged
terryjreedy merged 2 commits into
python:mainfrom
nedbat:nedbat/stack.append
Feb 15, 2024
Merged

docs: use consistent .append() in dis.rst#115434
terryjreedy merged 2 commits into
python:mainfrom
nedbat:nedbat/stack.append

Conversation

@nedbat

@nedbat nedbat commented Feb 13, 2024

Copy link
Copy Markdown
Member

The STACK variable is described as like a Python list, so pushing to it should be done with .append() consistently throughout.

As discussed at https://discuss.python.org/t/dis-py-stack-append-vs-stack-push/45330


📚 Documentation preview 📚: https://cpython-previews--115434.org.readthedocs.build/

@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Feb 13, 2024
@nedbat
nedbat requested a review from terryjreedy February 13, 2024 23:53
@terryjreedy
terryjreedy merged commit 4742047 into python:main Feb 15, 2024
@terryjreedy

Copy link
Copy Markdown
Member

The only instance of .push in 3.12 is the one before The operand determines which intrinsic function is called:. None in 3.11 doc. Not worth the backport hassle to me, but I would merge a backport if submitted and say how to do it if asked.

@nedbat
nedbat deleted the nedbat/stack.append branch February 16, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants