Skip to content

bpo-35733: isinstance(ast.Constant(True), ast.Num) is False#11547

Merged
serhiy-storchaka merged 3 commits into
python:masterfrom
asottile:bpo_35733
Jan 18, 2019
Merged

bpo-35733: isinstance(ast.Constant(True), ast.Num) is False#11547
serhiy-storchaka merged 3 commits into
python:masterfrom
asottile:bpo_35733

Conversation

@asottile

@asottile asottile commented Jan 14, 2019

Copy link
Copy Markdown
Contributor

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM.

Comment thread Lib/ast.py Outdated
Comment thread Lib/test/test_ast.py Outdated
Comment thread Misc/NEWS.d/next/Library/2019-01-13-18-42-41.bpo-35733.eFfLiv.rst Outdated
Comment thread Misc/NEWS.d/next/Library/2019-01-13-18-42-41.bpo-35733.eFfLiv.rst Outdated
@asottile

Copy link
Copy Markdown
Contributor Author

Updated! Thanks for the review 🎉

@asottile

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka anything left for me to do here?

@serhiy-storchaka serhiy-storchaka merged commit 7417622 into python:master Jan 18, 2019
@asottile asottile deleted the bpo_35733 branch January 18, 2019 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants