Skip to content

GH-116218 Docs: Add availability information for the 'resource' module#116256

Merged
ronaldoussoren merged 2 commits into
python:mainfrom
Privat33r-dev:docs-improve-116218
Mar 9, 2024
Merged

GH-116218 Docs: Add availability information for the 'resource' module#116256
ronaldoussoren merged 2 commits into
python:mainfrom
Privat33r-dev:docs-improve-116218

Conversation

@Privat33r-dev

@Privat33r-dev Privat33r-dev commented Mar 3, 2024

Copy link
Copy Markdown
Contributor

@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Mar 3, 2024
@Privat33r-dev Privat33r-dev changed the title GH-116218 Docs; Add availability information for the 'resource' module GH-116218 Docs: Add availability information for the 'resource' module Mar 3, 2024

@ronaldoussoren ronaldoussoren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some comments about the availability of a number of constants that have much wider availability than claimed by this PR.

I have not checked beyond macOS and FreeBSD, further resource is needed to update the availability statement. The constants I marked as being available on macOS and FreeBSD as well may well be available on all relevant unix-y platforms.

The symbols I marked as being part of the unix spec should IMHO not have availability information.

Comment thread Doc/library/resource.rst Outdated
This may result in the creation of a partial core file if a larger core would be
required to contain the entire process image.

.. availability:: Linux >= 1.3.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constant is part of the unix standard and should be available on all platforms (given that this module is documented as available on unix platforms).

Comment thread Doc/library/resource.rst Outdated
the :mod:`signal` module documentation for information about how to catch this
signal and do something useful, e.g. flush open files to disk.)

.. availability:: Linux >= 1.3.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise.

Comment thread Doc/library/resource.rst Outdated

The maximum size of a file which the process may create.

.. availability:: Linux >= 1.3.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise.

Comment thread Doc/library/resource.rst Outdated

The maximum size (in bytes) of the process's heap.

.. availability:: Linux >= 1.3.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise.

Comment thread Doc/library/resource.rst Outdated
The maximum size (in bytes) of the call stack for the current process. This only
affects the stack of the main thread in a multi-threaded process.

.. availability:: Linux >= 1.3.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise

Comment thread Doc/library/resource.rst Outdated

The maximum resident set size that should be made available to the process.

.. availability:: Linux >= 1.3.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also available on (at least) macOS and FreeBSD, not mentioned in the unix spec.

Comment thread Doc/library/resource.rst Outdated

The maximum number of processes the current process may create.

.. availability:: Linux >= 1.3.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also available on (at least) macOS and FreeBSD, not mentioned in the unix spec.

Comment thread Doc/library/resource.rst Outdated

The maximum number of open file descriptors for the current process.

.. availability:: Linux >= 1.3.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of the unix spec, see above

Comment thread Doc/library/resource.rst Outdated

The maximum area (in bytes) of address space which may be taken by the process.

.. availability:: Linux >= 1.3.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of the unix spec, see above.

@bedevere-app

bedevere-app Bot commented Mar 8, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Privat33r-dev

Privat33r-dev commented Mar 8, 2024

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

P.S. Thanks for the review.

@ronaldoussoren ronaldoussoren left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronaldoussoren ronaldoussoren added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Mar 9, 2024
@ronaldoussoren ronaldoussoren merged commit 03f86b1 into python:main Mar 9, 2024
@miss-islington-app

Copy link
Copy Markdown

Thanks @Privat33r-dev for the PR, and @ronaldoussoren for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 9, 2024
… module (pythonGH-116256)

Add availability data to 'resource' module Docs
(cherry picked from commit 03f86b1)

Co-authored-by: Kerim Kabirov <39376984+Privat33r-dev@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Mar 9, 2024

Copy link
Copy Markdown

GH-116533 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Mar 9, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 9, 2024
… module (pythonGH-116256)

Add availability data to 'resource' module Docs
(cherry picked from commit 03f86b1)

Co-authored-by: Kerim Kabirov <39376984+Privat33r-dev@users.noreply.github.com>
@bedevere-app

bedevere-app Bot commented Mar 9, 2024

Copy link
Copy Markdown

GH-116534 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Mar 9, 2024
ronaldoussoren pushed a commit that referenced this pull request Mar 9, 2024
…' module (GH-116256) (#116533)

GH-116218 Docs: Add availability information for the 'resource' module (GH-116256)

Add availability data to 'resource' module Docs
(cherry picked from commit 03f86b1)

Co-authored-by: Kerim Kabirov <39376984+Privat33r-dev@users.noreply.github.com>
ronaldoussoren pushed a commit that referenced this pull request Mar 9, 2024
…' module (GH-116256) (#116534)

GH-116218 Docs: Add availability information for the 'resource' module (GH-116256)

Add availability data to 'resource' module Docs
(cherry picked from commit 03f86b1)

Co-authored-by: Kerim Kabirov <39376984+Privat33r-dev@users.noreply.github.com>
@Privat33r-dev Privat33r-dev deleted the docs-improve-116218 branch March 9, 2024 22:42
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
… module (python#116256)

Add availability data to 'resource' module Docs
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
… module (python#116256)

Add availability data to 'resource' module Docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants