Skip to content

gh-117439: Make refleak checking thread-safe without the GIL#117469

Merged
colesbury merged 2 commits into
python:mainfrom
colesbury:gh-117439-reftotal
Apr 8, 2024
Merged

gh-117439: Make refleak checking thread-safe without the GIL#117469
colesbury merged 2 commits into
python:mainfrom
colesbury:gh-117439-reftotal

Conversation

@colesbury

@colesbury colesbury commented Apr 2, 2024

Copy link
Copy Markdown
Contributor

This keeps track of the per-thread total reference count operations in PyThreadState in the free-threaded builds. The count is merged into the interpreter's total when the thread exits.

This keeps track of the per-thread total reference count operations in
PyThreadState in the free-threaded builds. The count is merged into the
interpreter's total when the thread exits.

@DinoV DinoV left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread Objects/object.c Outdated

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@colesbury colesbury added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Apr 8, 2024
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit e3d02ca 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Apr 8, 2024
@colesbury
colesbury merged commit 1a6594f into python:main Apr 8, 2024
@colesbury
colesbury deleted the gh-117439-reftotal branch April 8, 2024 16:11
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
…ython#117469)

This keeps track of the per-thread total reference count operations in
PyThreadState in the free-threaded builds. The count is merged into the
interpreter's total when the thread exits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants