[3.12] gh-117613: Argument Clinic: ensure that defining_class params are positional-only#117939
Merged
Conversation
erlend-aasland
approved these changes
Apr 17, 2024
Contributor
|
Good sleuthing, @neonene! I applied a style nit. Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of #117781 and #117950 to 3.12 branch.
3.12 and 3.13 have almost the same issue, but
Modules/_sqlite/clinic/connection.c.hhas correctNUM_KEYWORDSon 3.12 so far:In old
clinic.py, the case above invokesparse_special_symbol(), which overwrites the kind ofdefining_classfromPOSITIONAL_OR_KEYWORDtoPOSITIONAL_ONLY:cpython/Tools/clinic/clinic.py
Lines 5073 to 5079 in aa26dc3
Fixing
defining_classparams instate_parameter()can cause theparse_special_symbol()above to fail:This PR avoids the error as well.
defining_classand no slash #117613