Skip to content

Revert 10245 msix#11873

Closed
mrtet wants to merge 5 commits into
masterfrom
revert-10245-msix
Closed

Revert 10245 msix#11873
mrtet wants to merge 5 commits into
masterfrom
revert-10245-msix

Conversation

@mrtet

@mrtet mrtet commented Feb 15, 2019

Copy link
Copy Markdown

No description provided.

@mrtet mrtet requested a review from a team as a code owner February 15, 2019 12:52
@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@eamanu eamanu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about this PR?

@matrixise

matrixise commented Feb 15, 2019

Copy link
Copy Markdown
Member

@vstinner @zware could you close this PR, I think it's bad PR :/

@zware zware closed this Feb 15, 2019
@zware zware deleted the revert-10245-msix branch February 15, 2019 15:04
@vstinner

Copy link
Copy Markdown
Member

@mrtet: Would you mind to elaborate a little bit why you would like to revert Steve Dower's @zooba PR #10245? The feature has been release in 3.7.2.

@zware

zware commented Feb 15, 2019

Copy link
Copy Markdown
Member

@vstinner This was your own branch in the main repository; I'm assuming this was a spam PR much like the ones we frequently get trying to merge 3.7 into master, for instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants