Skip to content

gh-118810: Allow the JSON encoder to optionally support decimal.Decimal objects#118811

Closed
chris-ashford wants to merge 4 commits into
python:mainfrom
chris-ashford:json_with_decimal
Closed

gh-118810: Allow the JSON encoder to optionally support decimal.Decimal objects#118811
chris-ashford wants to merge 4 commits into
python:mainfrom
chris-ashford:json_with_decimal

Conversation

@chris-ashford

@chris-ashford chris-ashford commented May 9, 2024

Copy link
Copy Markdown

My attempt at implementing what is described in #118810.
My first attempt at contributing to open source, so feedback is appreciated :)

@ghost

ghost commented May 9, 2024

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app

bedevere-app Bot commented May 9, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app

bedevere-app Bot commented May 9, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@chris-ashford

Copy link
Copy Markdown
Author

Apologies, I don't know how merge conflicts work and I thought that would fix it.

@savannahostrowski

Copy link
Copy Markdown
Member

Hey - thanks for the PR! I think @ezio-melotti and @rhettinger would be good reviewers for this change in json.

@chris-ashford chris-ashford deleted the json_with_decimal branch May 10, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants