gh-120258: Correct MIME type for .ass files#120252
Closed
rcombs wants to merge 2 commits into
Closed
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Advanced SubStation is a common subtitle format, and the ".ass" extension is not commonly used for AAC audio files.
rcombs
changed the title
rcombs
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
I did some research and found that although .ass subtitle files are more common these days, .ass is also an IANA registered file type for the audio type: https://www.iana.org/assignments/media-types/audio/aac. So, I think we can't change it directly. Moreover, the mimetypes package not only uses this predefined map in the source code, it also uses the system's mimetype database to get the associated mimetypes from the file extension, and Debian uses data from IANA: https://salsa.debian.org/debian/media-types/-/blob/master/mime.types#L1681 |
Member
|
Closing as per #120258 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Advanced SubStation is a common subtitle format, and the ".ass" extension is not commonly used for AAC audio files.