Skip to content

[3.7] bpo-36096: IDLE: Refactor class variables in colorizer (GH-12002)#12069

Closed
miss-islington wants to merge 1 commit into
python:3.7from
miss-islington:backport-ed1deb0-3.7
Closed

[3.7] bpo-36096: IDLE: Refactor class variables in colorizer (GH-12002)#12069
miss-islington wants to merge 1 commit into
python:3.7from
miss-islington:backport-ed1deb0-3.7

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 27, 2019

Copy link
Copy Markdown
Contributor

(cherry picked from commit ed1deb0)

Co-authored-by: Cheryl Sabella cheryl.sabella@gmail.com

https://bugs.python.org/issue36096

(cherry picked from commit ed1deb0)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>

@csabella csabella left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🤖

@miss-islington

Copy link
Copy Markdown
Contributor Author

@csabella: Status check is done, and it's a failure ❌ .

1 similar comment
@miss-islington

Copy link
Copy Markdown
Contributor Author

@csabella: Status check is done, and it's a failure ❌ .

@csabella csabella closed this Feb 27, 2019
@miss-islington miss-islington deleted the backport-ed1deb0-3.7 branch February 27, 2019 17:24
@terryjreedy

Copy link
Copy Markdown
Member

Did the test result box disappear before or after you closed this? I would not be surprised if the failures were related to the buildbot failures for the 3.8 merge -- a problem with an external resource. So I suspect you should have rerun, if possible, after some wait. I will trigger another backport.

@csabella

Copy link
Copy Markdown
Contributor

The test failures were related to buildbot failures, but I'm not sure when the result box disappeared. I thought if I closed the PR and reopen it, then it would trigger the status checks to run again. That's what I've done on my PRs in the past. But, once I closed it, Miss Islington deleted her branch and I wasn't able to re-open it. I didn't know how to rerun without closing the PR. Sorry about the mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants