Skip to content

gh-120726: Fix warnings#120727

Merged
vstinner merged 4 commits into
python:mainfrom
Eclips4:issue-120726
Jun 19, 2024
Merged

gh-120726: Fix warnings#120727
vstinner merged 4 commits into
python:mainfrom
Eclips4:issue-120726

Conversation

@Eclips4

@Eclips4 Eclips4 commented Jun 19, 2024 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@Eclips4 Eclips4 requested a review from vstinner June 19, 2024 06:38
@bedevere-app bedevere-app Bot mentioned this pull request Jun 19, 2024
Closed
@nineteendo

nineteendo commented Jun 19, 2024

Copy link
Copy Markdown
Contributor

Thanks, I had noticed this a few times already, but thought it was a macOS issue.

@Eclips4

Eclips4 commented Jun 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Uhm, I guess we need another approach to do this instead of define these functions only if Py_DEBUG is defined. Maybe convert them to macroses and define them only if Py_DEBUG defined?
UPD: I've found different approach.

serhiy-storchaka
serhiy-storchaka reviewed Jun 19, 2024
View reviewed changes
Comment thread Python/import.c Outdated
@Eclips4 @serhiy-storchaka
Update Python/import.c
4e3b9a5 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
vstinner
vstinner approved these changes Jun 19, 2024
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But next time, try to find a better PR title, since this one is very generic. I will enhance it when I will merge your PR.

@vstinner vstinner enabled auto-merge (squash) June 19, 2024 07:34
@vstinner vstinner merged commit a816cd6 into python:main Jun 19, 2024
@nineteendo

nineteendo commented Jun 19, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Do we backport this or do we close the issue?

https://github.com/python/cpython/blob/3.13/Python/import.c

@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Jun 19, 2024
@miss-islington-app

miss-islington-app Bot commented Jun 19, 2024

Copy link
Copy Markdown

Thanks @Eclips4 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2024
@Eclips4 @miss-islington
pythongh-120726: Fix compiler warnings on is_core_module() (pythonGH-…
9bd9548 
…120727)

Fix compiler warnings on is_core_module() and
check_interpreter_whence(): only define them when
assertions are built.
(cherry picked from commit a816cd6)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@bedevere-app

bedevere-app Bot commented Jun 19, 2024

Copy link
Copy Markdown

GH-120729 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 19, 2024
@vstinner

vstinner commented Jun 19, 2024

Copy link
Copy Markdown
Member

Do we backport this or do we close the issue?

I didn't know that 3.13 was affected. I backported the change.

vstinner pushed a commit that referenced this pull request Jun 19, 2024
@miss-islington @Eclips4
[3.13] gh-120726: Fix compiler warnings on is_core_module() (GH-120727)…
071b66b 
… (#120729)

gh-120726: Fix compiler warnings on is_core_module() (GH-120727)

Fix compiler warnings on is_core_module() and
check_interpreter_whence(): only define them when
assertions are built.
(cherry picked from commit a816cd6)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@Eclips4 Eclips4 deleted the issue-120726 branch June 19, 2024 10:31
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@Eclips4 @mrahtz
pythongh-120726: Fix compiler warnings on is_core_module() (python#12…
0973182 
…0727)

Fix compiler warnings on is_core_module() and
check_interpreter_whence(): only define them when
assertions are built.
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@Eclips4 @noahbkim
pythongh-120726: Fix compiler warnings on is_core_module() (python#12…
75b3bfd 
…0727)

Fix compiler warnings on is_core_module() and
check_interpreter_whence(): only define them when
assertions are built.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@Eclips4 @estyxx
pythongh-120726: Fix compiler warnings on is_core_module() (python#12…
3786e2c 
…0727)

Fix compiler warnings on is_core_module() and
check_interpreter_whence(): only define them when
assertions are built.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments
@vstinner vstinner vstinner approved these changes
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Eclips4 @nineteendo @vstinner @serhiy-storchaka