Skip to content

bpo-36504: Fix signed integer overflow in _ctypes.c's PyCArrayType_new()#12660

Merged
serhiy-storchaka merged 1 commit into
python:masterfrom
ZackerySpytz:bpo-36504-overflow-PyCArrayType_new
Apr 2, 2019
Merged

bpo-36504: Fix signed integer overflow in _ctypes.c's PyCArrayType_new()#12660
serhiy-storchaka merged 1 commit into
python:masterfrom
ZackerySpytz:bpo-36504-overflow-PyCArrayType_new

Conversation

@ZackerySpytz

@ZackerySpytz ZackerySpytz commented Apr 2, 2019 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 3.6 and removed needs backport to 3.6 labels Apr 2, 2019
@serhiy-storchaka serhiy-storchaka merged commit 487b73a into python:master Apr 2, 2019
@miss-islington

miss-islington commented Apr 2, 2019

Copy link
Copy Markdown
Contributor

Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7.
🐍🍒⛏🤖

@ZackerySpytz

ZackerySpytz commented Apr 3, 2019

Copy link
Copy Markdown
Contributor Author

Hi, @serhiy-storchaka. It seems that the bot failed to create the backports?

@miss-islington

miss-islington commented Apr 3, 2019

Copy link
Copy Markdown
Contributor

Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Apr 3, 2019

Copy link
Copy Markdown
Contributor

Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

miss-islington commented Apr 3, 2019

Copy link
Copy Markdown
Contributor

Sorry, @ZackerySpytz and @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 487b73ab39c80157474821ef9083f51e0846bd62 2.7

@bedevere-bot

bedevere-bot commented Apr 3, 2019

Copy link
Copy Markdown

GH-12676 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 3, 2019
@ZackerySpytz @miss-islington
bpo-36504: Fix signed integer overflow in _ctypes.c's PyCArrayType_ne…
c8a2c06 
…w(). (pythonGH-12660)

(cherry picked from commit 487b73a)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@serhiy-storchaka

serhiy-storchaka commented Apr 3, 2019

Copy link
Copy Markdown
Member

Do you mind to create a backport to 2.7 manually if the bug exists in 2.7?

miss-islington added a commit that referenced this pull request Apr 3, 2019
@miss-islington @ZackerySpytz
bpo-36504: Fix signed integer overflow in _ctypes.c's PyCArrayType_ne…
9c08eeb 
…w(). (GH-12660)

(cherry picked from commit 487b73a)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
ZackerySpytz added a commit to ZackerySpytz/cpython that referenced this pull request Apr 3, 2019
@ZackerySpytz
bpo-36504: Fix signed integer overflow in _ctypes.c's PyCArrayType_ne…
489569a 
…w(). (pythonGH-12660)

(cherry picked from commit 487b73a)
@bedevere-bot

bedevere-bot commented Apr 3, 2019

Copy link
Copy Markdown

GH-12678 is a backport of this pull request to the 2.7 branch.

@ZackerySpytz

ZackerySpytz commented Apr 3, 2019

Copy link
Copy Markdown
Contributor Author

I created the backport to 2.7.

serhiy-storchaka pushed a commit that referenced this pull request Apr 3, 2019
@ZackerySpytz @serhiy-storchaka
bpo-36504: Fix signed integer overflow in _ctypes.c's PyCArrayType_ne…
fd83a82 
…w(). (GH-12660) (GH-12678)

(cherry picked from commit 487b73a)
eric-wieser
eric-wieser reviewed Jun 7, 2019
View reviewed changes
Comment thread Modules/_ctypes/_ctypes.c

itemsize = itemdict->size;
if (length * itemsize < 0) {
if (length > PY_SSIZE_T_MAX / itemsize) {

@eric-wieser eric-wieser Jun 7, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Divide-by-zero for:

class S(ctypes.Structure): _fields_ = []

(S*10)()

bpo13881

@serhiy-storchaka serhiy-storchaka removed their assignment Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
+1 more reviewer
@eric-wieser eric-wieser eric-wieser left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZackerySpytz @miss-islington @bedevere-bot @serhiy-storchaka @eric-wieser @the-knights-who-say-ni