Skip to content

Fix typo - #12878

Merged
miss-islington merged 1 commit into
python:masterfrom
fredrikaverpil:asyncio-typo
Apr 20, 2019
Merged

Fix typo#12878
miss-islington merged 1 commit into
python:masterfrom
fredrikaverpil:asyncio-typo

Conversation

@fredrikaverpil

@fredrikaverpil fredrikaverpil commented Apr 18, 2019

Copy link
Copy Markdown
Contributor

"sychronization" -> "synchronization"

@fredrikaverpil
Fix typo
2f07a26 
"sychronization" -> "synchronization"
@the-knights-who-say-ni

the-knights-who-say-ni commented Apr 18, 2019

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 18, 2019
@fredrikaverpil

fredrikaverpil commented Apr 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Not sure if it's really needed, but I signed the CLA.

Edit: not sure why the CLA username check says I haven't signed the CLA... but I did and received the signed PDF on my mail and all. Also made sure my bpo account has my GitHub username properly entered.

tirkarthi
tirkarthi approved these changes Apr 19, 2019
View reviewed changes

@tirkarthi tirkarthi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@asvetlov

asvetlov commented Apr 19, 2019

Copy link
Copy Markdown
Contributor

CLA approval requires human action, it takes about a day usually.

@asvetlov asvetlov self-assigned this Apr 19, 2019
@miss-islington
miss-islington merged commit 3e986de into python:master Apr 20, 2019
@miss-islington

miss-islington commented Apr 20, 2019

Copy link
Copy Markdown
Contributor

Thanks @fredrikaverpil for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 20, 2019
@fredrikaverpil @miss-islington
Fix typo (pythonGH-12878)
98ff2a3 
"sychronization" -> "synchronization"
(cherry picked from commit 3e986de)

Co-authored-by: Fredrik Averpil <fredrik@averpil.com>
@bedevere-bot

bedevere-bot commented Apr 20, 2019

Copy link
Copy Markdown

GH-12890 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Apr 20, 2019
@miss-islington @fredrikaverpil
Fix typo (GH-12878)
307e7a4 
"sychronization" -> "synchronization"
(cherry picked from commit 3e986de)

Co-authored-by: Fredrik Averpil <fredrik@averpil.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes
@tirkarthi tirkarthi tirkarthi approved these changes
@1st1 1st1 Awaiting requested review from 1st1
+1 more reviewer
@ZackerySpytz ZackerySpytz ZackerySpytz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@asvetlov asvetlov

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@fredrikaverpil @the-knights-who-say-ni @asvetlov @miss-islington @bedevere-bot @tirkarthi @ZackerySpytz