remove type annotations from multiprocessing. - #129381
Merged
Merged
Conversation
One of them was technically invalid per typing specs... but since we're not checking these in the stdlib today lets elide them. https://discuss.python.org/t/static-type-annotations-in-cpython/65068/13
gpshead
added
skip issue
skip news
needs backport to 3.13
webknjaz
reviewed
Jan 27, 2025
Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 30, 2025
* remove type annotations from multiprocessing. One of them was technically invalid per typing specs... but since we're not checking these in the stdlib today lets elide them. https://discuss.python.org/t/static-type-annotations-in-cpython/65068/13 * use the actual comment style annotation format Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua> --------- (cherry picked from commit 71aecc2) Co-authored-by: Gregory P. Smith <greg@krypto.org> Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
|
GH-129470 is a backport of this pull request to the 3.13 branch. |
|
Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 30, 2025
* remove type annotations from multiprocessing. One of them was technically invalid per typing specs... but since we're not checking these in the stdlib today lets elide them. https://discuss.python.org/t/static-type-annotations-in-cpython/65068/13 * use the actual comment style annotation format Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua> --------- (cherry picked from commit 71aecc2) Co-authored-by: Gregory P. Smith <greg@krypto.org> Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
|
GH-129471 is a backport of this pull request to the 3.12 branch. |
gpshead
added a commit
that referenced
this pull request
Jan 30, 2025
…9470) remove type annotations from multiprocessing. (GH-129381) * remove type annotations from multiprocessing. One of them was technically invalid per typing specs... but since we're not checking these in the stdlib today lets elide them. https://discuss.python.org/t/static-type-annotations-in-cpython/65068/13 * use the actual comment style annotation format --------- (cherry picked from commit 71aecc2) Co-authored-by: Gregory P. Smith <greg@krypto.org> Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
gpshead
added a commit
that referenced
this pull request
Jan 30, 2025
…9471) remove type annotations from multiprocessing. (GH-129381) * remove type annotations from multiprocessing. One of them was technically invalid per typing specs... but since we're not checking these in the stdlib today lets elide them. https://discuss.python.org/t/static-type-annotations-in-cpython/65068/13 * use the actual comment style annotation format --------- (cherry picked from commit 71aecc2) Co-authored-by: Gregory P. Smith <greg@krypto.org> Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Feb 7, 2025
* remove type annotations from multiprocessing. One of them was technically invalid per typing specs... but since we're not checking these in the stdlib today lets elide them. https://discuss.python.org/t/static-type-annotations-in-cpython/65068/13 * use the actual comment style annotation format Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua> --------- Co-authored-by: 🇺🇦 Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of them was technically invalid per typing specs... but since we're not checking these in the stdlib today lets elide them.
https://discuss.python.org/t/static-type-annotations-in-cpython/65068/13