gh-101944: correct typo in the comment of PyModule_AddObjectRef#129659
Closed
asdfefbhjy wants to merge 4 commits into
Closed
gh-101944: correct typo in the comment of PyModule_AddObjectRef#129659asdfefbhjy wants to merge 4 commits into
PyModule_AddObjectRef#129659asdfefbhjy wants to merge 4 commits into
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
picnixz
changed the title
PyModule_AddObjectRef
picnixz
reviewed
Feb 9, 2025
| wchar_t *ptr; | ||
| wchar_t option; | ||
|
|
||
| if (*opt_ptr == '\0') { |
Member
There was a problem hiding this comment.
This is unrelated to the issue at hand, so please revert.
Author
There was a problem hiding this comment.
I always want to make some almost useless modification to the source code when I study the CPython internals. If I submit a PR for every modification, it will waste a lot of time. So I will close this PR. I hope I will make some substantial contribution to CPython in the near future. Thank you for your time !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2025/2/9 9:50: I always want to make some almost useless modification to the source code when I study the CPython internals. If I submit a PR for every modification, it will waste a lot of time. So I will close this PR. I hope I will make some substantial contribution to CPython in the near future. Thank you for your time !