Conversation
The reference to `__iter__` method seems to mean `object.__iter__`, not `iterator.__iter__`.
picnixz
left a comment
There was a problem hiding this comment.
In the iterator term, we have:
Iterator are required to have an :meth:`~iterator.__iter__` method that returns the iterator
which is correct. Can you check if there are other mentions to iterator.__iter__ when we actually mean object.__iter__?
|
I also looked for some other files and found some incorrect links in |
iterator.__next__
iterator.__next__iterator.__iter__
picnixz
left a comment
There was a problem hiding this comment.
I hope we don't have more __iter__ usages. If you want, you can perhaps look at the other __iter__ usages that were actually iterator.__iter__ and not object.__iter__ or not !__iter__ and vice-versa?
|
All of these usages are correct except as corrected in this PR. (Some of them are |
|
Thanks @koyuki7w for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
These references to an `__iter__` method mean `object.__iter__`, not `iterator.__iter__`. (cherry picked from commit 4d3a7ea) Co-authored-by: Yuki Kobayashi <drsuaimqjgar@gmail.com>
|
GH-130543 is a backport of this pull request to the 3.13 branch. |
These references to an `__iter__` method mean `object.__iter__`, not `iterator.__iter__`. (cherry picked from commit 4d3a7ea) Co-authored-by: Yuki Kobayashi <drsuaimqjgar@gmail.com>
|
GH-130544 is a backport of this pull request to the 3.12 branch. |
The reference to
__iter__method seems to meanobject.__iter__, notiterator.__iter__.📚 Documentation preview 📚: https://cpython-previews--130172.org.readthedocs.build/