[3.13] Use os.openpty() instead of pty.openpty() in test_ioctl#132878
Conversation
pty.openpty() does not work on Android, and it is easier to check availability of os.openpty.
|
!buildbot Android |
|
🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit af45ba0 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132878%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
|
See #132848 (comment). It is weird that only 3.13 fails. I am going to apply the same change to main after testing it for 3.13. There is no benefit of using pty.openpty() over os.openpty(), because the tests fail if os.openpty() does not work. |
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
But it's kind of unusual to make a change first in 3.13, and then forward-port it to the main branch. I would suggest to start on main and then backport.
|
This is because the issue can only be reproduced in 3.13, so it is not possible to test the solution in main. |
pty.openpty() does not work on Android, and it is easier to check availability of os.openpty.