Skip to content

[3.13] Use os.openpty() instead of pty.openpty() in test_ioctl#132878

Merged
serhiy-storchaka merged 1 commit into
python:3.13from
serhiy-storchaka:test-ioctl4-3.13
Apr 24, 2025
Merged

[3.13] Use os.openpty() instead of pty.openpty() in test_ioctl#132878
serhiy-storchaka merged 1 commit into
python:3.13from
serhiy-storchaka:test-ioctl4-3.13

Conversation

@serhiy-storchaka

Copy link
Copy Markdown
Member

pty.openpty() does not work on Android, and it is easier to check availability of os.openpty.

pty.openpty() does not work on Android, and it is easier to check
availability of os.openpty.
@serhiy-storchaka

Copy link
Copy Markdown
Member Author

!buildbot Android

@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit af45ba0 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F132878%2Fmerge

The command will test the builders whose names match following regular expression: Android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

@serhiy-storchaka

Copy link
Copy Markdown
Member Author

See #132848 (comment).

It is weird that only 3.13 fails. I am going to apply the same change to main after testing it for 3.13.

There is no benefit of using pty.openpty() over os.openpty(), because the tests fail if os.openpty() does not work.

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

But it's kind of unusual to make a change first in 3.13, and then forward-port it to the main branch. I would suggest to start on main and then backport.

@serhiy-storchaka

Copy link
Copy Markdown
Member Author

This is because the issue can only be reproduced in 3.13, so it is not possible to test the solution in main.

@serhiy-storchaka serhiy-storchaka merged commit bf6c74d into python:3.13 Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants