gh-90733: improve hashlib.scrypt interface#136100
Merged
Merged
Conversation
picnixz
force-pushed
the
fix/hashlib/openssl-scrypt-90733
branch
from
June 29, 2025 14:08
9f92510 to
eb1565c
Compare
picnixz
force-pushed
the
fix/hashlib/openssl-scrypt-90733
branch
from
June 29, 2025 14:30
eb1565c to
0adf063
Compare
Member
Author
|
!buildbot FIPS only |
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 0adf063 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136100%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
picnixz
marked this pull request as draft
July 13, 2025 11:38
|
All commit authors signed the Contributor License Agreement. |
Member
Author
|
HA. I merged in the wrong order! |
picnixz
force-pushed
the
fix/hashlib/openssl-scrypt-90733
branch
from
July 13, 2025 11:43
1503249 to
0adf063
Compare
picnixz
marked this pull request as ready for review
July 13, 2025 11:44
Member
Author
|
!buildbot FIPS only |
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 41646c4 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136100%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
* add `scrypt` to `hashlib.__all__` * improve `hashlib.scrypt` exception messages
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
* add `scrypt` to `hashlib.__all__` * improve `hashlib.scrypt` exception messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scryptis now unconditionally available so there's no need for this additional definescryptin__all__so I exposed itmaxmemanddklenare too restrictive in its current form, but it's also fine in some sense as allowing for a largermaxmemalso means removing protections and allowing for VERY largedklenisn't necessary.