Skip to content

gh-136032: Fix argparse.BooleanOptionalAction doc#136133

Merged
savannahostrowski merged 5 commits into
python:mainfrom
mattwang44:fix-argparse-BooleanOptionalAction-doc
Jul 5, 2025
Merged

gh-136032: Fix argparse.BooleanOptionalAction doc#136133
savannahostrowski merged 5 commits into
python:mainfrom
mattwang44:fix-argparse-BooleanOptionalAction-doc

Conversation

@mattwang44

@mattwang44 mattwang44 commented Jun 30, 2025 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Jun 30, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Jun 30, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 30, 2025
Closed
@mattwang44 mattwang44 force-pushed the fix-argparse-BooleanOptionalAction-doc branch from 075b1c9 to e4b9fd5 Compare June 30, 2025 14:57
mattwang44
mattwang44 commented Jun 30, 2025
View reviewed changes
Comment thread Doc/library/argparse.rst Outdated
savannahostrowski
savannahostrowski requested changes Jul 1, 2025
View reviewed changes

@savannahostrowski savannahostrowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I think your suggestion to move BooleanOptionalAction is solid. Wording is also great, just one small comment

Comment thread Doc/library/argparse.rst Outdated
Comment thread Doc/library/argparse.rst Outdated
@bedevere-app

bedevere-app Bot commented Jul 1, 2025

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@mattwang44

mattwang44 commented Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

@bedevere-app

bedevere-app Bot commented Jul 1, 2025

Copy link
Copy Markdown

Thanks for making the requested changes!

@savannahostrowski: please review the changes made to this pull request.

@bedevere-app bedevere-app Bot requested a review from savannahostrowski July 1, 2025 07:03
serhiy-storchaka
serhiy-storchaka reviewed Jul 3, 2025
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much clearer than the old documentation.

Comment thread Doc/library/argparse.rst Outdated
@mattwang44 mattwang44 force-pushed the fix-argparse-BooleanOptionalAction-doc branch from d618477 to fbd30a5 Compare July 3, 2025 19:28
serhiy-storchaka
serhiy-storchaka approved these changes Jul 3, 2025
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

For future, please avoid rebase and force-push. It is easier to review if you can see only new changes.

Comment thread Doc/library/argparse.rst
@savannahostrowski savannahostrowski added the needs backport to 3.13 bugs and security fixes label Jul 5, 2025
@savannahostrowski savannahostrowski added the needs backport to 3.14 bugs and security fixes label Jul 5, 2025
savannahostrowski
savannahostrowski approved these changes Jul 5, 2025
View reviewed changes

@savannahostrowski savannahostrowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks so much for this!

@savannahostrowski savannahostrowski merged commit 1953713 into python:main Jul 5, 2025
29 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jul 5, 2025
@miss-islington-app

miss-islington-app Bot commented Jul 5, 2025

Copy link
Copy Markdown

Thanks @mattwang44 for the PR, and @savannahostrowski for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2025
@mattwang44 @miss-islington
pythongh-136032: Fix argparse.BooleanOptionalAction doc (pythonGH-1…
85bc430 
…36133)

(cherry picked from commit 1953713)

Co-authored-by: W. H. Wang <mattwang44@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2025
@mattwang44 @miss-islington
pythongh-136032: Fix argparse.BooleanOptionalAction doc (pythonGH-1…
d318b9a 
…36133)

(cherry picked from commit 1953713)

Co-authored-by: W. H. Wang <mattwang44@gmail.com>
@bedevere-app

bedevere-app Bot commented Jul 5, 2025

Copy link
Copy Markdown

GH-136329 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 5, 2025
@bedevere-app

bedevere-app Bot commented Jul 5, 2025

Copy link
Copy Markdown

GH-136330 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 5, 2025
@mattwang44 mattwang44 deleted the fix-argparse-BooleanOptionalAction-doc branch July 6, 2025 01:55
savannahostrowski pushed a commit that referenced this pull request Jul 8, 2025
@miss-islington @mattwang44
[3.13] gh-136032: Fix argparse.BooleanOptionalAction doc (GH-136133) (
095715c 
#136330)

gh-136032: Fix `argparse.BooleanOptionalAction` doc (GH-136133)
(cherry picked from commit 1953713)

Co-authored-by: W. H. Wang <mattwang44@gmail.com>
savannahostrowski pushed a commit that referenced this pull request Jul 8, 2025
@miss-islington @mattwang44
[3.14] gh-136032: Fix argparse.BooleanOptionalAction doc (GH-136133) (
e1e9d95 
#136329)

gh-136032: Fix `argparse.BooleanOptionalAction` doc (GH-136133)
(cherry picked from commit 1953713)

Co-authored-by: W. H. Wang <mattwang44@gmail.com>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@mattwang44 @AndPuQing
pythongh-136032: Fix argparse.BooleanOptionalAction doc (python#136133
516d1ee 
)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@mattwang44 @Pranjal095
pythongh-136032: Fix argparse.BooleanOptionalAction doc (python#136133
489965a 
)
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
@mattwang44 @picnixz
pythongh-136032: Fix argparse.BooleanOptionalAction doc (python#136133
787c5d7 
)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@mattwang44 @taegyunkim
pythongh-136032: Fix argparse.BooleanOptionalAction doc (python#136133
3d2825d 
)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@mattwang44 @Agent-Hellboy
pythongh-136032: Fix argparse.BooleanOptionalAction doc (python#136133
8184c24 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@savannahostrowski savannahostrowski savannahostrowski approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattwang44 @serhiy-storchaka @savannahostrowski